-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: split metrics into its own api package #1797
chore!: split metrics into its own api package #1797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1797 +/- ##
==========================================
+ Coverage 92.12% 92.61% +0.49%
==========================================
Files 163 174 +11
Lines 5484 6042 +558
Branches 1177 1283 +106
==========================================
+ Hits 5052 5596 +544
- Misses 432 446 +14
|
@open-telemetry/javascript-approvers this is extremely important for the API release so please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, many changes :).
Can we have a new folder "types" inside api metrics and then move there all interfaces ? Currently we have interfaces and noop Implementations together in main folder, this could help organise stuff WDYT ?
@obecny made all requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Create new
@opentelemetry/metrics-api
packageFollow up:
api-common
package for shared things like logging interface?api-metrics
just depends onapi
to get these things.