fix(@opentelemetry/exporter-jaeger): fixed issue #1757 #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debagger
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1758 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 166 166
Lines 5593 5593
Branches 1199 1199
=======================================
Hits 5150 5150
Misses 443 443
|
vmarchaud
approved these changes
Dec 17, 2020
naseemkullah
approved these changes
Dec 17, 2020
dyladan
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Jaeger exporter set error tag when span status is Unset as discribed in issue #1757
Short description of the changes
Changed error flag setting logic
Added test for this