-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Link to spec versioning doc #1737
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1737 +/- ##
==========================================
+ Coverage 92.79% 92.81% +0.01%
==========================================
Files 144 144
Lines 5178 5178
Branches 1062 1062
==========================================
+ Hits 4805 4806 +1
+ Misses 373 372 -1
|
lgtm. |
The only word we have from @tedsuo is "years". They don't expect to go to 2.0 any time soon. |
RELEASING.md
Outdated
|
||
- The `examples/` and `getting-started/` folders are not part of lerna packages, we need to manually bump the version in `package.json`. | ||
|
||
## Versioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall i'm fine (plus the modification discussed about the SIG), could we add a link to this inside the readme ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, remove experiential, use version 0, new package for new (significant?) experimental changes, don't rev the API version for every change (unless the API explicitly changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RELEASING.md
Outdated
|
||
#### V1.0.0 Release (tracing, baggage, propagators, context) | ||
|
||
- `@opentelemetry/[email protected]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the versioning OTEP, they want each signal to have its own API package. This package would then just depend on the stable API packages and re-export them. What do we think of that idea?
@open-telemetry/javascript-maintainers @open-telemetry/javascript-approvers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see the advantages of doing this apart for more work when releasing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure I would split api, about the rest hard to say, for using on daily basis I would rather have them together in one repo and keep the version aligned (all except api).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure I would split api
@obecny you would have a separate package for each trace, context, metrics, etc? Or do you just mean metrics would be split?
What if we only have separate API packages and remove the "main" API package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we can have only api seperate and the rest that would be the easiest, otherwise I would have:
- api
- metrics (until it is stable)
- all the rest
RELEASING.md
Outdated
|
||
#### Immature or experimental signals | ||
|
||
API modules for experimental signals will not be included in the `@opentelemetry/api` module, and must be installed manually. API modules will be named with an `-experimental` suffix to make it abundantly clear that depending on them is at your own risk. For example, the `@opentelemetry/metrics-api-experimental` module will provide experimental access to the unfinished metrics API. NO STABILITY GUARANTEES ARE MADE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we agreed to remove the -experimental
suffix at the SIG meeting. It looks like the "versioning" section was updated, but this might have been missed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Based on comments and against the main OTEP and looking at what Java is doing, it doesn't appear to be that the usage of additional "suffixes" 1.0.0-alpha is explicitly "banned" but rather the issue was called out based on language specific "tools" that don't fully support semver 2.0. While I agree with the general sentiment of using 0.x.y for experimental (for the initial situation we are in), I think we should also consider including the "-alpha" / "-beta" suffixes especially moving forward for adding additional changes to existing packages, rather than creating a brand new and starting @ v 0.x.y (for adding future changes) as I believe this will get us back into the same situation and reason that we are dropping the "-expermential" suffix on the package name. Thoughts? |
Can you give an example of a time in which we would have the choice between a The idea seems to be predicated on new features relating to mature signals, which the spec and TC have explicitly stated will not happen. |
Assuming that we are going to be able to release a "perfect" version across all packages is quite simply not realistic... We WILL need to add new (non-breaking) features to existing packages. And I believe that the simple act of creating the next version violates your statement, whether that is a minor bump or major. Or are we declaring that we are only EVER going to release v1.0.x and NEVER release any "pre" (alpha/beta) package for future versions (containing new integrations or features)? Yes, I am specifically ignoring this statement "We currently have no plans for deprecating signals or creating a major version past v1.0." as this is a short-term view and in my view will get violated not long after we GA (or possible before as part of considering adding packages) So I'm going to flip your question around and ask "Why would you want to create a new package for the next version of an existing package?" (as I believe this assertion takes us back to the -experiential situation again) Example from Trasks's comment on the main OTEP. |
Based on the updated OTEP, the usage of suffixes is now the suggestion, unless not supported by the language/build environments, with GO the only called out instance. Do we have anyone in the JS community that is using a build environment that would barf if we used suffixes? |
Not that I'm aware of. |
Is that still required @dyladan ? |
AH I thought this had been merged. Yes this is still a requirement. We will also need one on the API repo. I'll make sure it's compatible with the latest spec versioning doc and update it today. thanks for the heads up |
@dyladan ping ;) |
@vmarchaud pong :) I'll do this today |
@dyladan ping |
Creating a JS versioning proposal as requested in open-telemetry/opentelemetry-specification#1267
/cc @tedsuo