-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: moving plugin from api to core #1715
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 165 165
Lines 5138 5138
Branches 1056 1056
=======================================
Hits 4694 4694
Misses 444 444
|
Not sure here but isn't instrumentation the component for all the plugin topics? Or would this result in some weird circular dependency? |
Right now we have 2 ways to write instrumentations. The old way with "plugins" that use the BasePlugin class in the core module, and the new way which uses the Instrumentation base class in the instrumentation package. The old way will be deprecated when we finish migrating our existing instrumentations to the new way. The old plugin config interface was in the API package for some reason and this just moves it to core to live with the BasePlugin |
Which problem is this PR solving?
Short description of the changes