Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moving plugin from api to core #1715

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Conversation

obecny
Copy link
Member

@obecny obecny commented Dec 4, 2020

Which problem is this PR solving?

Short description of the changes

  • Move plugin interfaces out of API package

@obecny obecny self-assigned this Dec 4, 2020
@obecny obecny added enhancement New feature or request breaking labels Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1715 (9f50196) into master (86cbd67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1715   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         165      165           
  Lines        5138     5138           
  Branches     1056     1056           
=======================================
  Hits         4694     4694           
  Misses        444      444           
Impacted Files Coverage Δ
...ntelemetry-core/src/platform/BaseAbstractPlugin.ts 60.00% <ø> (ø)
...opentelemetry-core/src/platform/node/BasePlugin.ts 81.08% <ø> (ø)
...telemetry-node/src/instrumentation/PluginLoader.ts 93.82% <ø> (ø)
packages/opentelemetry-plugin-fetch/src/fetch.ts 96.55% <ø> (ø)

@obecny obecny mentioned this pull request Dec 4, 2020
@Flarna
Copy link
Member

Flarna commented Dec 7, 2020

Not sure here but isn't instrumentation the component for all the plugin topics? Or would this result in some weird circular dependency?

@dyladan
Copy link
Member

dyladan commented Dec 7, 2020

Not sure here but isn't instrumentation the component for all the plugin topics? Or would this result in some weird circular dependency?

Right now we have 2 ways to write instrumentations. The old way with "plugins" that use the BasePlugin class in the core module, and the new way which uses the Instrumentation base class in the instrumentation package. The old way will be deprecated when we finish migrating our existing instrumentations to the new way. The old plugin config interface was in the API package for some reason and this just moves it to core to live with the BasePlugin

@obecny obecny merged commit 91612c4 into open-telemetry:master Dec 8, 2020
@obecny obecny deleted the plugin branch December 8, 2020 13:27
naseemkullah pushed a commit to naseemkullah/opentelemetry-js that referenced this pull request Dec 23, 2020
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move plugin interfaces out of API package
5 participants