Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter-collector): implement concurrencyLimit option #1708

Merged
merged 3 commits into from
Dec 10, 2020

Commits on Dec 3, 2020

  1. feat(exporter-collector): implement concurrencyLimit option

    This adds an option to the collector exporters `concurrencyLimit`.  If this is set and
    the number of export operations is equal to the limit, additional export operations
    will fail immediately.
    
    This should be set in combination with the batch span processor be set such that the
    concurrency limit would not be reached under "normal" circumstances - only if there
    is an issue would spans start to be dropped.
    
    This helps us cap the amount of memory & sockets used by the exporter if it is not
    able to keep up with the data it is being provided.
    
    This could happen if the local network (e.g. in a browser) or the remote collector
    are too slow to handle all the activity.
    
     If we do not have this cap, and the exporter cannot keep up, resources such as
     memory and network sockets can be consumed without limit, causing crashes and
     other undesirable outcomes far worse than losing some telemetry data.
    
     This also updates the examples to use `BatchSpanProcessor` as I couldn't really
     think of any reason why you would want to use SimpleSpanProcessor in combination
     with the collector exporter.
    dobesv committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    279c2d9 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2020

  1. Configuration menu
    Copy the full SHA
    ed67c82 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Configuration menu
    Copy the full SHA
    2eda370 View commit details
    Browse the repository at this point in the history