chore: use WebTracerProvider instead of WebTracer in docs #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrosty
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 165 165
Lines 5053 5053
Branches 1044 1044
=======================================
Hits 4619 4619
Misses 434 434 |
|
@bradfrosty pls sign the |
dyladan
reviewed
Nov 25, 2020
| import { ZoneContextManager } from '@opentelemetry/context-zone'; | ||
|
|
||
| const webTracerWithZone = new WebTracer({ | ||
| const providerWithZone = new WebTracer(); |
There was a problem hiding this comment.
- change to provider
|
@obecny working to get the CLA signed on my end |
bradfrosty
force-pushed
the
bf/update-context-zone-docs
branch
from
04b9202 to
b0845fd
Compare
bradfrosty
force-pushed
the
bf/update-context-zone-docs
branch
from
b0845fd to
e5e57da
Compare
|
@obecny signed! Good to merge? |
dyladan
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
I didn't make an issue, as it seemed simple enough. A few packages were using
WebTraceras opposed toWebTracerProviderin their examples. It seems like this may have been removed from the exports in@opentelemetry/web(please correct me if wrong), so these examples are out of date. Regardless, there is some inconsistency.Short description of the changes
Update examples to use
WebTracerProviderand specifycontextManagerin theregister()method as opposed to on instantiation of provider.