feat(semantic-conventions): FaaS specifications #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirsky
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1670 +/- ##
==========================================
- Coverage 91.39% 91.37% -0.02%
==========================================
Files 165 165
Lines 5053 5053
Branches 1045 1045
==========================================
- Hits 4618 4617 -1
- Misses 435 436 +1
|
vmarchaud
approved these changes
Nov 11, 2020
dyladan
approved these changes
Nov 11, 2020
naseemkullah
approved these changes
Nov 11, 2020
naseemkullah
requested changes
Nov 11, 2020
naseemkullah
approved these changes
Nov 11, 2020
|
Please update the branch or check the box to allow maintainers to edit |
obecny
reviewed
Nov 11, 2020
obecny
reviewed
Nov 11, 2020
obecny
approved these changes
Nov 11, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* move type to dev dependencies * chore(deps): upgrade @types/koa__router dependency * move types to internal-types * fix formatting * formatting * Revert "formatting" This reverts commit b3484061b9120f22a528ade70c3109dc0eb9fd0a. * Revert "fix formatting" This reverts commit 7c604461fe5f0c5380aa3d94e34998bb4a803324. * Revert "move types to internal-types" This reverts commit 0eea74522e32ceaa656d0e6edfaa44d897bb0c65. * moving KoaMiddleware to internal-types * fix formatting * fix formatting * fix formatting --------- Co-authored-by: Amir Blum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding FaaS specifications to semantic-conventions package, as described here.