Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make prometheus histogram export cumulative #1570

Merged
merged 6 commits into from
Oct 8, 2020

Conversation

AndrewGrachov
Copy link
Contributor

Which problem is this PR solving?

  • According to prometheus histogram docs, these histograms should be cumulative. This will allow us to measure estimated quantiles, as we do with raw prometheus

Short description of the changes

  • Export histogram as cumulative (e.g

1 to 100 bucket,
1 to 200,
1 to 400 bucket will result in:

1 to 100 bucket ,
2 to 200 bucket
3 to 400 bucket
3 to +inf bucket

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #1570 into master will decrease coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
- Coverage   93.24%   92.99%   -0.25%     
==========================================
  Files         133      158      +25     
  Lines        3775     4911    +1136     
  Branches      727      992     +265     
==========================================
+ Hits         3520     4567    +1047     
- Misses        255      344      +89     
Impacted Files Coverage Δ
...ry-exporter-prometheus/src/PrometheusSerializer.ts 96.22% <100.00%> (+0.07%) ⬆️
...-plugin-grpc-js/src/server/clientStreamAndUnary.ts 100.00% <0.00%> (ø)
packages/opentelemetry-plugin-grpc/src/grpc.ts 93.71% <0.00%> (ø)
...opentelemetry-core/src/platform/node/timer-util.ts 50.00% <0.00%> (ø)
packages/opentelemetry-plugin-grpc-js/src/utils.ts 92.30% <0.00%> (ø)
...ackages/opentelemetry-plugin-grpc-js/src/grpcJs.ts 100.00% <0.00%> (ø)
packages/opentelemetry-plugin-http/src/utils.ts 97.36% <0.00%> (ø)
...ces/src/platform/node/detectors/ProcessDetector.ts 100.00% <0.00%> (ø)
packages/opentelemetry-plugin-grpc/src/utils.ts 90.90% <0.00%> (ø)
...ntelemetry-core/src/platform/node/hex-to-base64.ts 100.00% <0.00%> (ø)
... and 19 more

@dyladan dyladan added the enhancement New feature or request label Oct 8, 2020
@dyladan dyladan merged commit ae1185d into open-telemetry:master Oct 8, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants