-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove process listener #1522
Remove process listener #1522
Conversation
533e2a3
to
a0b3de0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1522 +/- ##
==========================================
- Coverage 93.82% 93.28% -0.55%
==========================================
Files 154 153 -1
Lines 4761 4750 -11
Branches 952 950 -2
==========================================
- Hits 4467 4431 -36
- Misses 294 319 +25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
I would just add an example (in getting started for example or more appropriate place) to show people that if they want to mimic the removed behaviour in node they should simply listen for sigterm and call shutdown of tracer etc..
|
Graceful shutdown support was removed via open-telemetry#1522 Remove the corresponding configuration because it is not used anymore. Refs: open-telemetry#1321
Graceful shutdown support was removed via open-telemetry/opentelemetry-js#1522 Remove the corresponding configuration because it is not used anymore. Refs: open-telemetry/opentelemetry-js#1321
Graceful shutdown support was removed via open-telemetry/opentelemetry-js#1522 Remove the corresponding configuration because it is not used anymore. Refs: open-telemetry/opentelemetry-js#1321
Fixes #1521
Replaces #1501