-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-http): remove path from span name #1466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 154 154
Lines 4762 4762
Branches 951 951
=======================================
Hits 4468 4468
Misses 294 294
|
I think you have to fix the tests, thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because the changes look good, but the tests must be fixed before merge.
I can't figure out how my change could affect coverage. Can anyone help me find what needs to be fixed? |
I would guess that all of the failures are because the span names are being asserted in the tests like here https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-plugin-http/test/integrations/http-enable.test.ts#L292 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Resolves #897.
According to otel spec:
This PR removes
pathname
from span name. So span names will be like in spec:HTTP GET
.I assume that framework instrumentations will add parameterized routes to the span names (like express-plugin does).