-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add a new plugin base decoupled from the sdk #1449
WIP: add a new plugin base decoupled from the sdk #1449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, one question is this only for node ? If so maybe name should have node
word otherwise the semver
usage should be moved to platform
folder
this._meter = meterProvider.getMeter(this.instrumentationName, this.instrumentationVersion); | ||
} | ||
|
||
protected get tracer(): Tracer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are basically not using get/set approach in our sdk so would rather have getTracer
, getMeter
to just unify all , WDYT ?
So far I have been focusing on node but I hope that the module will eventually be useful for both web and node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine 👍
Another question that comes though my mind is since the API is changed a bit, how do handle old plugin loading AND new ones ? Or there will be a breaking change here ?
The new plugin loader depends on API only, so it doesn't actually depend on any plugin load mechanism at all so the old plugins will still work. I think for now this will just be an alternative plugin load mechanism, then when all plugins have been migrated we can remove the old plugin loader. |
I think this can be closed already @dyladan |
* Add process metrics in @opentelemetry/host-metrics * Lint --------- Co-authored-by: Marc Pichler <[email protected]> Co-authored-by: Haddas Bronfman <[email protected]>
This new plugin base is completely decoupled from the SDK and relies only on the API. After #1448 plugins using this base class will be able to be fully standalone, and will support instrumenting modules very early in the load process, even before the tracer provider is set up.