Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default url for otelcol #1254

Merged
merged 6 commits into from
Jun 29, 2020
Merged

fix: default url for otelcol #1254

merged 6 commits into from
Jun 29, 2020

Conversation

jufab
Copy link
Contributor

@jufab jufab commented Jun 28, 2020

Which problem is this PR solving?

  • The default port of Opentelemetry collector

Short description of the changes

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 28, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jun 28, 2020 •
edited
Loading

Codecov Report

Merging #1254 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1254   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         126      126           
  Lines        3597     3597           
  Branches      724      724           
=======================================
  Hits         3356     3356           
  Misses        241      241

obecny
obecny reviewed Jun 29, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update also examples/collector-exporter-node

@mayurkale22 mayurkale22 requested a review from obecny June 29, 2020 20:44
@mayurkale22
Copy link
Member

This is good to go, please resolve the conflicts.

@mayurkale22
Copy link
Member

Welcome to OpenTelemetry community and congrats for first contribution.

@mayurkale22 mayurkale22 merged commit 5aa851a into open-telemetry:master Jun 29, 2020
@davidwitten davidwitten mentioned this pull request Jun 29, 2020
Merged
@jufab jufab deleted the default-url-otelcol branch June 30, 2020 23:03
@dyladan dyladan added the bug Something isn't working label Jul 6, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@blumamir
fix(graphql): graphql instrumentation throw for sync calls (open-tele…
524d98e 
…metry#1254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obecny obecny obecny approved these changes

@dyladan dyladan dyladan approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@naseemkullah naseemkullah naseemkullah approved these changes

@bg451 bg451 Awaiting requested review from bg451

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@mwear mwear Awaiting requested review from mwear

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jufab @mayurkale22 @obecny @dyladan @vmarchaud @naseemkullah