Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about endpoint config option #1234

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

danielmbarlow
Copy link
Contributor

Which problem is this PR solving?

The documentation didn't show that the URL for the endpoint config option should include /api/traces

Short description of the changes

I added an extra option to the usage documentation example

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #1234 into master will increase coverage by 1.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   92.05%   93.24%   +1.18%     
==========================================
  Files         102      122      +20     
  Lines        2367     3551    +1184     
  Branches      431      714     +283     
==========================================
+ Hits         2179     3311    +1132     
- Misses        188      240      +52     
Impacted Files Coverage Δ
packages/opentelemetry-plugin-https/src/utils.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-exporter-zipkin/src/types.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-exporter-zipkin/src/utils.ts 100.00% <0.00%> (ø)
packages/opentelemetry-node/src/config.ts 100.00% <0.00%> (ø)
packages/opentelemetry-plugin-grpc/src/utils.ts 93.75% <0.00%> (ø)
...pentelemetry-exporter-prometheus/src/prometheus.ts 91.39% <0.00%> (ø)
...ackages/opentelemetry-exporter-jaeger/src/utils.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-exporter-jaeger/src/types.ts 100.00% <0.00%> (ø)
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0.00%> (ø)
packages/opentelemetry-plugin-http/src/utils.ts 97.42% <0.00%> (ø)
... and 10 more

@mayurkale22
Copy link
Member

Welcome to OpenTelemetry Community!

@mayurkale22 mayurkale22 merged commit 66f49a7 into open-telemetry:master Jun 24, 2020
@dyladan dyladan added the document Documentation-related label Jul 6, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants