-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add node-plugins-all package #1181
Merged
dyladan
merged 9 commits into
open-telemetry:master
from
dynatrace-oss-contrib:plugins-all
Jun 17, 2020
Merged
feat: add node-plugins-all package #1181
dyladan
merged 9 commits into
open-telemetry:master
from
dynatrace-oss-contrib:plugins-all
Jun 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
June 10, 2020 14:07
Codecov Report
@@ Coverage Diff @@
## master #1181 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 122 122
Lines 3533 3533
Branches 714 714
=======================================
Hits 3262 3262
Misses 271 271 |
markwolff
approved these changes
Jun 10, 2020
mayurkale22
approved these changes
Jun 10, 2020
andrewhsu
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrewhsu
reviewed
Jun 10, 2020
andrewhsu
reviewed
Jun 10, 2020
mwear
approved these changes
Jun 11, 2020
naseemkullah
approved these changes
Jun 12, 2020
mayurkale22
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Jun 13, 2020
vmarchaud
approved these changes
Jun 13, 2020
obecny
approved these changes
Jun 15, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* added another block to test for v2 * feat: changing export name to reflect generic docker * feat: adding geenric naming and logic changes to support cgroup v2 * test: test file renamed * feat: adding hostname check * feat: adding hostname check- refactor * feat: fixed a test and fixed lint * feat: added another condition to check for length * test: added two more tests * feat: renamed docker to container and addressed pr comments * feat: renamed docker to container and addressed pr comments- 2 * feat: renamed docker to container and addressed pr comments-3 * feat: addressed pr comments-2 * feat: modified tests to take in multiple lines input * feat: merge resolution for manifest * feat: fixing release please manifest * feat: changing please-config to rename docker to container * feat: replaced >= check to == check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @andrewhsu