-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update prom-client to 12.0.0 #1139
update prom-client to 12.0.0 #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming tests pass
Looks like this was a breaking change in prom-client which will require some additional work to handle. |
I think build is failing due to siimon/prom-client#299, prom-client v12.0.0 introduced some breaking changes. |
In siimon/prom-client#333 timestamp support is removed from the prom-client library. |
fwiw labelValues will be removed via #1126 |
No they will not. Just labelKeys. |
1170553
to
ff2524e
Compare
|
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
that makes sense |
@@ -140,7 +136,6 @@ export class PrometheusExporter implements MetricExporter { | |||
metric.inc( | |||
labelValues, | |||
point.value as Sum, | |||
hrTimeToMilliseconds(point.timestamp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this not needed anymore ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 12 of the prom client removed the timestamp siimon/prom-client#333
Hi @shivkanya9146 could you please resolve the conflicts? |
|
Which problem is this PR solving?
-update prom-client
Short description of the changes
-updated prom-client to 12.0.0