fix(http-plugin): don't modify user's headers object in plugin #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
dyladan
approved these changes
May 14, 2020
From the code it looks like Jaeger Exporter is using UDP, so it should not be affected. |
There was a PR to introduce http sending... possible it wasn't merged yet. Ah yes #965 still open. Thanks for the fix. |
vmarchaud
approved these changes
May 14, 2020
|
@OlivierAlbertini as original plugin author would be nice to get your 👍 here |
mayurkale22
approved these changes
May 14, 2020
OlivierAlbertini
approved these changes
May 16, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Rauno Viskus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #1059
Zipkin exporter is constructing an
headersobject once and then use the same object in all http outgoing requests to Zipkin server. If the http plugin delete a key from the headers object, it affects following requests which are sent without OT header, thus being traced and create infinite loop of spans.Short description of the changes
When http plugin receive outgoing request with OT header, it first clone the headers object, and then
deletefrom the clone without modifying the original user's object.