fix readme: setting labelKeys when creating the counter #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luebken
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
luebken
changed the title
dyladan
approved these changes
May 14, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…try#1056) * feat(lru-memoizer): add instrumentation for lru-memoizer * fix(lru-memoizer): typescript issues in test * fix(auto-instrumentation): fix tests * chore: downgrade expect to support node 8 * chore(lru-memoizer): fix expect version * fix(lru-memoizer): typos and rephrase * chore(lru-memoizer): comments rephrases * style(lru-memoizer): unified suppored versions * style(lru-memoizer): better wording in README * fix(lru-memoizer): check cb before binding Co-authored-by: Rauno Viskus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes