chore(opentelemetry-resources): add instance type and az to aws detector #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinwalz
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
justinwalz
force-pushed
the
feature/update-aws-detector
branch
from
7666839 to
89e47d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 213 213
Lines 8950 8950
Branches 806 806
=======================================
Hits 8514 8514
Misses 436 436
|
mayurkale22
reviewed
May 14, 2020
packages/opentelemetry-resources/src/platform/node/detectors/AwsEc2Detector.ts
Show resolved
Hide resolved
packages/opentelemetry-resources/src/platform/node/detectors/AwsEc2Detector.ts
Show resolved
Hide resolved
mayurkale22
added
enhancement
justinwalz
force-pushed
the
feature/update-aws-detector
branch
from
89e47d4 to
f1246dd
Compare
|
Pushed updated commit for added tests. |
mayurkale22
approved these changes
May 14, 2020
|
Please fix the lint (run: |
Signed-off-by: Justin Walz <[email protected]>
justinwalz
force-pushed
the
feature/update-aws-detector
branch
from
f1246dd to
70242cf
Compare
dyladan
approved these changes
May 14, 2020
|
@mayurkale22 if we want this in 0.8.1 we should merge it. It's simple enough that I'm ok to merge it if you are. Or we can wait for another review. |
|
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…pen-telemetry#1055) Co-authored-by: Rauno Viskus <[email protected]> Co-authored-by: Rauno Viskus <[email protected]> Co-authored-by: Valentin Marchaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great work on this project. I noticed these two items were missing when implementing a custom detector for our system. Figured I'd add it here as well.
Signed-off-by: Justin Walz [email protected]
Short description of the changes
Added:
cloud.zoneandhost.typeto aws ec2 detector.