Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): span processor should receive a readable span as parameters #1037

Merged
merged 1 commit into from
May 8, 2020

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Removed tracing.Span.toReadableSpan as tracing.Spans are already implements ReadableSpan.

@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #1037 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   95.13%   95.13%   -0.01%     
==========================================
  Files         212      212              
  Lines        8899     8895       -4     
  Branches      801      801              
==========================================
- Hits         8466     8462       -4     
  Misses        433      433              
Impacted Files Coverage Δ
...entelemetry-exporter-zipkin/test/transform.test.ts 100.00% <ø> (ø)
packages/opentelemetry-tracing/src/Span.ts 100.00% <ø> (ø)
...lemetry-plugin-http/test/functionals/utils.test.ts 99.40% <100.00%> (ø)
...es/opentelemetry-tracing/src/MultiSpanProcessor.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 60.00% <100.00%> (ø)
...telemetry-tracing/src/export/BatchSpanProcessor.ts 95.74% <100.00%> (ø)
...elemetry-tracing/src/export/SimpleSpanProcessor.ts 78.57% <100.00%> (ø)
...ntelemetry-tracing/test/MultiSpanProcessor.test.ts 93.10% <100.00%> (+1.10%) ⬆️
packages/opentelemetry-tracing/test/Span.test.ts 100.00% <100.00%> (ø)

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@mayurkale22 mayurkale22 added the enhancement New feature or request label May 8, 2020
@mayurkale22 mayurkale22 merged commit 45ea74a into open-telemetry:master May 8, 2020
@legendecas legendecas deleted the span-processor branch May 9, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom SpanProcessors api definition issue
5 participants