Codecov: Fix file path prefixes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
requested review from
danielkhan,
iredelmeier,
justindsmith,
mayurkale22 and
rochdev
as code owners
Totally agree. I would suggest to open an issue to address it. |
mayurkale22
approved these changes
Jul 12, 2019
This was referenced Jul 12, 2019
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Valentin Marchaud <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Valentin Marchaud <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
Sample Generated Report - only core has a non-empty report for now
5e7b244 removes the publishing of the report of
opentelemetry-scope-basebecause it was an empty report. Codecov seems to error out every report if any are empty, so this should be added back in (with-p ../../) when there is code to be coverage checked.Opting to use method proposed here so that all script logic is located in each
package.json, instead of scanning for (non-empty) coverage reports in circleCI yaml.It might also be a good idea to separate generation and publishing of reports as in https://github.com/vmarchaud/openprofiling-node/blob/master/packages/openprofiling-core/package.json#L12, since local dev box will never need to publish coverage reports.