fix(opentelemetry-plugin-xml-http-request): define span kind as CLIENT for xmlhttprequests #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T for xmlhttprequests
ivansenic
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
vmarchaud
approved these changes
Apr 30, 2020
|
@ivansenic Thanks for taking the time to make that PR ! You'll just need to sign the CLA (see: https://identity.linuxfoundation.org/projects/cncf) |
|
@vmarchaud No problem. I signed the CLA. |
dyladan
approved these changes
Apr 30, 2020
|
@obecny please take a look at this one. If you're ok I'll merge it. |
mayurkale22
approved these changes
Apr 30, 2020
|
Thanks for the PR @ivansenic and welcome to Opentelemetry community! |
mayurkale22
reviewed
Apr 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
===========================================
- Coverage 95.00% 82.38% -12.62%
===========================================
Files 212 80 -132
Lines 8806 2101 -6705
Branches 796 296 -500
===========================================
- Hits 8366 1731 -6635
+ Misses 440 370 -70
|
markwolff
approved these changes
May 1, 2020
mayurkale22
approved these changes
May 1, 2020
|
@ivansenic please fix the lint ( |
@mayurkale22 Sorry for that, my bad.. Fixed and pushed. |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
xml-http-requestplugin does not correctly set the span kind toCLIENTwhen creating the span on the open method. This makes all spans that represent XHR requests having the default span kind ofINTERNAL.Per spec
INTERNAL -> Default value. Indicates that the span is used internally., which in this case is not true and should beCLIENT -> Indicates that the span covers the client-side wrapper around an RPC or other remote request..Short description of the changes
One-liner to set the span kind to
CLIENT.