Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(http-plugin): x-opentelemetry-outgoing-request isn't stripped before sending the request #983

Closed
vmarchaud opened this issue Apr 26, 2020 · 5 comments · Fixed by #984
Closed

bug(http-plugin): x-opentelemetry-outgoing-request isn't stripped before sending the request #983

vmarchaud opened this issue Apr 26, 2020 · 5 comments · Fixed by #984
Assignees
@vmarchaud
Labels
bug Something isn't working

Comments

@vmarchaud
Copy link
Member

vmarchaud commented Apr 26, 2020 •
edited
Loading

It can create some issues for remote server that doesn't expect that header, ex:
openzipkin/zipkin-support#6
Anyway we shouldn't mutate the request from a external point of view

ref: #965 (comment)
@vmarchaud vmarchaud added the bug Something isn't working label Apr 26, 2020
@vmarchaud vmarchaud mentioned this issue Apr 26, 2020
Closed
@vmarchaud
Copy link
Member Author

we should trip it there: https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-plugin-http/src/http.ts#L384

@vmarchaud vmarchaud self-assigned this Apr 26, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Apr 26, 2020
@vmarchaud
fix(http-plugin): strip otel custom http header open-telemetry#983
65988bd
@vmarchaud vmarchaud mentioned this issue Apr 26, 2020
Merged
@dyladan dyladan linked a pull request Apr 29, 2020 that will close this issue
fix(http-plugin): strip otel custom http header #983 #984
Merged
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 2, 2020
@vmarchaud
fix(http-plugin): strip otel custom http header open-telemetry#983
da78f3e
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 10, 2020
@vmarchaud
fix(http-plugin): strip otel custom http header open-telemetry#983
5b9e397
mayurkale22 pushed a commit that referenced this issue May 11, 2020
@vmarchaud
fix(http-plugin): strip otel custom http header #983 (#984)
35cda77
@acheraime
Copy link

Anybody knows when this change will be available in npmjs? I'm experiencing the same issue when using exporter-zipkin to jaeger.

@mayurkale22
Copy link
Member

We have planned to cut release this week, waiting to few PRs to get merged. Let us know if you blocked on this, we can cut release either today or tomorrow.

@acheraime
Copy link

Yes I am blocked on it. I have a demo tomorrow and this is a big show stopper now.

@dyladan
Copy link
Member

dyladan commented May 11, 2020

This is a good reason why using the header to signal to plugins is a bad idea.

@sergioregueira sergioregueira mentioned this issue Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmarchaud vmarchaud

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(http-plugin): strip otel custom http header #983 vmarchaud/opentelemetry-js
4 participants
@acheraime @dyladan @vmarchaud @mayurkale22