Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use url.URL in http and https plugins #938

Closed
dyladan opened this issue Apr 7, 2020 · 1 comment · Fixed by #960
Closed

use url.URL in http and https plugins #938

dyladan opened this issue Apr 7, 2020 · 1 comment · Fixed by #960
Assignees
@naseemkullah

Comments

@dyladan
Copy link
Member

dyladan commented Apr 7, 2020

The current http/https plugins use the global URL which comes from the dom lib. All instances of URL should be replaced with url.URL from the standard library.
@naseemkullah
Copy link
Member

🙋‍♂️

@naseemkullah naseemkullah mentioned this issue Apr 12, 2020
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@dyladan
chore: add fs to release config (open-telemetry#938)
cc37e3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naseemkullah naseemkullah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[http] fix: use url.URL naseemkullah/opentelemetry-js
2 participants
@dyladan @naseemkullah