Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TSLint rule to enforce Apache headers in every file #43

Closed
rochdev opened this issue Jun 19, 2019 · 5 comments · Fixed by #258
Closed

Add TSLint rule to enforce Apache headers in every file #43

rochdev opened this issue Jun 19, 2019 · 5 comments · Fixed by #258
Labels
feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@rochdev
Copy link
Member

rochdev commented Jun 19, 2019

Is your feature request related to a problem? Please describe.

As discussed in #33, the license should be added automatically to every file to avoid users forgetting to add it, or add it in an inconsistent way.

Describe the solution you'd like

TSLint can be used for this purpose with the file-header rule. The header should also be reduced to a minimal copyright notice to avoid polluting every file with a large block of license at the top.

Describe alternatives you've considered

Alternatively, we could use a license that doesn't strongly suggest a per-file license. Unfortunately, right now Apache-2.0 is enforced by CNCF so this will need to be discussed outside the scope of this project.

@rochdev
Copy link
Member Author

rochdev commented Jun 19, 2019

@caniszczyk @bogdandrutu Could you confirm what a minimal one-liner license would look like as discussed in open-telemetry/community#113?

@caniszczyk
Copy link

sorry something like:

// Copyright OpenTelemetry Contributors. SPDX-License-Identifier: Apache-2.0

@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jul 4, 2019
@mayurkale22
Copy link
Member

// Copyright OpenTelemetry Contributors. SPDX-License-Identifier: Apache-2.0

@draffensperger FYI

@draffensperger
Copy link
Contributor

@mayurkale22 did you get official confirmation from CNCF folks that this short form header is allowed?

@OlivierAlbertini
Copy link
Member

Any news on this issue ? I'm waiting to merge this one for doing #165

dyladan pushed a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
* chore: renaming noop span to non recording span

* chore: adding upgrade guidelines fixing links
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
* chore: renaming noop span to non recording span

* chore: adding upgrade guidelines fixing links
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
…rent-express

improv(express): require parent span #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants