-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parseKeyPairsIntoRecord does not parse if value conatains equals #3974
Labels
bug
Something isn't working
priority:p2
Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Comments
6 tasks
pichlermarc
added
priority:p2
Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
and removed
triage
labels
Jul 10, 2023
Hi, thanks for reaching out. |
@pichlermarc yes please assign it to me! thanks |
pichlermarc
added a commit
that referenced
this issue
Aug 7, 2023
) Co-authored-by: Marc Pichler <[email protected]>
This was referenced Nov 27, 2023
[Snyk] Security upgrade @opentelemetry/sdk-node from 0.40.0 to 0.41.2
sumodgeorge/opentelemetry-js#7
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
priority:p2
Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
What happened?
Steps to Reproduce
Expected Result
the above example should parse the value to
{ key: 'aGVsbG8gd29ybGQhOiE6IQ==' }
Actual Result
the above example is returning
{}
Additional Details
according to https://github.com/w3c/baggage/blob/main/baggage/HTTP_HEADER_FORMAT.md,
value MAY contain any number of the equal sign (=) characters. Parsers MUST NOT assume that the equal sign is only used to separate key and value.
however, parseKeyPairsIntoRecord is assuming the equal sign is only a key separator
OpenTelemetry Setup Code
No response
package.json
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: