Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add droppedAttributesCount field to ReadableLogRecord #3758

Closed
martinkuba opened this issue Apr 25, 2023 · 1 comment · Fixed by #4289
Closed

Add droppedAttributesCount field to ReadableLogRecord #3758

martinkuba opened this issue Apr 25, 2023 · 1 comment · Fixed by #4289
Labels
feature-request sdk:logs Issues and PRs related to the Logs SDK

Comments

@martinkuba
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Per spec here, the ReadableLogRecord should provide the number of dropped attributes. Also see the logs data model here.

Describe the solution you'd like

This change should provide the field to exporters. The Logger should also be updated to populate the field.
@martinkuba martinkuba added feature-request sdk:logs Issues and PRs related to the Logs SDK labels Apr 25, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jun 26, 2023
@pichlermarc pichlermarc removed the stale label Jun 27, 2023
HyunnoH added a commit to HyunnoH/opentelemetry-js that referenced this issue Oct 9, 2023
@HyunnoH
feat(sdk-logs): add droppedAttributesCount in ReadableLogRecord (open…
0c776a0 
…-telemetry#3758)
HyunnoH added a commit to HyunnoH/opentelemetry-js that referenced this issue Oct 9, 2023
@HyunnoH
feat(sdk-logs): add droppedAttributesCount in ReadableLogRecord (open…
f1898bf 
…-telemetry#3758)
@HyunnoH HyunnoH mentioned this issue Nov 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request sdk:logs Issues and PRs related to the Logs SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdk-logs): add droppedAttributesCount field to ReadableLogRecord HyunnoH/opentelemetry-js
2 participants
@martinkuba @pichlermarc