Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(instrumentation-http): move sdk-metrics to dev dependencies #3380

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

@opentelemetry/instrumentation-http currently depends on @opentelemetry/sdk-metrics, this is not necessary, as it does not use anything from the SDK outside of the tests.

Short description of the changes

Moves @opentelemetry/sdk-metrics to devDependencies.

Type of change

  • dependencies

How Has This Been Tested?

  • Existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@pichlermarc pichlermarc marked this pull request as ready for review November 3, 2022 09:33
@pichlermarc pichlermarc requested a review from a team November 3, 2022 09:33
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #3380 (a93c6f4) into main (1536a7c) will increase coverage by 0.41%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3380      +/-   ##
==========================================
+ Coverage   92.83%   93.25%   +0.41%     
==========================================
  Files         232      247      +15     
  Lines        6605     7341     +736     
  Branches     1362     1509     +147     
==========================================
+ Hits         6132     6846     +714     
- Misses        473      495      +22     
Impacted Files Coverage Δ
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.58% <0.00%> (ø)
...entelemetry-sdk-trace-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
...ckages/opentelemetry-sdk-trace-web/karma.worker.js 100.00% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 97.02% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/types.ts 100.00% <0.00%> (ø)
...ntelemetry-resources/src/detectors/NoopDetector.ts 100.00% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
... and 11 more

@pichlermarc pichlermarc changed the title deps(instrumentation-http): move sdk-metrics to dev dependencies. deps(instrumentation-http): move sdk-metrics to dev dependencies Nov 4, 2022
@pichlermarc pichlermarc merged commit d154066 into open-telemetry:main Nov 4, 2022
@pichlermarc pichlermarc deleted the deps/instr-http branch November 4, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants