Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Histogram sum is exported on instruments that allow negative measurements #3090

Closed
pichlermarc opened this issue Jul 13, 2022 · 1 comment · Fixed by #3102
Closed

Histogram sum is exported on instruments that allow negative measurements #3090

pichlermarc opened this issue Jul 13, 2022 · 1 comment · Fixed by #3102
Assignees
@pichlermarc
Labels
spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug
Milestone
Metrics GA

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Jul 13, 2022 •
edited
Loading

With a Histogram Aggregation, sum is currently collected even when using instruments like UpDownCounter or ObservableGauge, which allow negative measurements.

The specification states this:

Arithmetic sum of Measurement values in population. This SHOULD NOT be collected when used with
instruments that record negative measurements (e.g. UpDownCounter or ObservableGauge).

Therefore we should not collect the sum when using instruments that allow negative measurements.
@pichlermarc pichlermarc added the spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug label Jul 13, 2022
@pichlermarc pichlermarc added this to the Metrics GA milestone Jul 13, 2022
@pichlermarc
Copy link
Member Author

I'll self-assign and start working on this. 🙂

@pichlermarc pichlermarc self-assigned this Jul 13, 2022
@pichlermarc pichlermarc changed the title Histogram sum is exported on non-monotonic instruments Histogram sum is exported on instruments that allow non-negative measurements Jul 13, 2022
@pichlermarc pichlermarc changed the title Histogram sum is exported on instruments that allow non-negative measurements Histogram sum is exported on instruments that allow negative measurements Jul 13, 2022
This was referenced Jul 15, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pichlermarc pichlermarc

Labels
spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug
Projects
None yet
Milestone
Metrics GA
1 participant
@pichlermarc