null port when using ignore matchers in opentelemetry-instrumentation-http

[danielgblanco]

What version of OpenTelemetry are you using?

npm list
[email protected] ~/test
├── @opentelemetry/[email protected]
├── @opentelemetry/[email protected]
├── @opentelemetry/[email protected]
└── [email protected]

What version of Node are you using?

node --version
v16.14.0

Please provide the code you used to setup the OpenTelemetry SDK

const { NodeTracerProvider } =  require('@opentelemetry/sdk-trace-node');
const {HttpInstrumentation} = require('@opentelemetry/instrumentation-http');

const instrumentation = new HttpInstrumentation();
const provider = new NodeTracerProvider();
instrumentation.setTracerProvider(provider);
instrumentation.enable();

const axios = require('axios');

const ignoreMatcher = (url) => {
  console.info(`${typeof url}: ${url}`)
  return new URL(url).hostname.endsWith('example.com');
}

instrumentation.setConfig({
  ignoreOutgoingUrls: [
    ignoreMatcher
  ],
});

What did you do?

axios.get(
  'http://example.com',
).then();

What did you expect to see?

string: http://example.com/

What did you see instead?

string: http://example.com:null/

Additional context

There seems to be an issue in the opentelemetry-instrumentation-http when getting request info on a request passed as a string to Axios on default port. The code here expects a port but the options object looks something like.

{
  "maxRedirects": 21,
  "maxBodyLength": 10485760,
  "protocol": "http:",
  "path": "/",
  "method": "GET",
  "headers": {
    "Accept": "application/json, text/plain, */*",
    "User-Agent": "axios/0.27.2"
  },
  "agents": {},
  "hostname": "example.com",
  "port": null,
  "nativeProtocols": {...},
  "pathname": "/"
}

This is not a critical issue, but it means that origin passed to isIgnored here may not be correctly formatted, thus potentially resulting in exceptions thrown (when trying to cast into URL) or matching not occurring (if trying to match a string).

[dyladan]

Assigned you since you're already working here

[danielgblanco]

Thanks, yes the PR linked above should close this.