Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: tracing sdk depend on src dir from core #2177

Closed
vmarchaud opened this issue May 2, 2021 · 0 comments · Fixed by #2178
Closed

bug: tracing sdk depend on src dir from core #2177

vmarchaud opened this issue May 2, 2021 · 0 comments · Fixed by #2178
Assignees
@vmarchaud
Labels
bug Something isn't working

Comments

@vmarchaud
Copy link
Member

https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-tracing/src/config.ts#L26
@vmarchaud vmarchaud added the bug Something isn't working label May 2, 2021
@vmarchaud vmarchaud self-assigned this May 2, 2021
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 2, 2021
@vmarchaud
chore(tracing): dont use internal core type open-telemetry#2177
a289eeb
@vmarchaud vmarchaud mentioned this issue May 2, 2021
Merged
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 8, 2021
@vmarchaud
chore(tracing): dont use internal core type open-telemetry#2177
139c0c4
vmarchaud added a commit that referenced this issue May 11, 2021
@vmarchaud @dyladan
chore(tracing): dont use internal core type #2177 (#2178)
5cd02aa 
Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmarchaud vmarchaud

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tracing): dont use internal core type #2177 vmarchaud/opentelemetry-js
1 participant
@vmarchaud