-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting the exported service name using the JAEGER_SERVICE_NAME environment variable #1565
Comments
Interesting, thanks for pointing that out! I think ideally both In this case though, there's no OTEL equivalent to the |
What should be the precedence between the two? Jaeger has announced deprecation of it's agent/collector in favour of OpenTelemetry.
I could find Also, the parameters used to intialize the Exporter are different across languages. Example: agent host is specified as |
Closing as not planned as |
Is your feature request related to a problem? Please describe.
Quite a few options for the Jaeger exporter can already be configured using the JAEGER_ environment variables. However, the service name cannot.
Describe the solution you'd like
Allow setting the exported service name using the JAEGER_SERVICE_NAME environment variable.
Describe alternatives you've considered
Manually set the service name from the env vars:
Additional context
To implement, a single line may be added to https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-exporter-jaeger/src/jaeger.ts#L53. I can give it a whirl :)
The text was updated successfully, but these errors were encountered: