Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align opentelemetry instrumentation naming with specification #1095

Closed
toumorokoshi opened this issue May 21, 2020 · 4 comments
Closed

align opentelemetry instrumentation naming with specification #1095

toumorokoshi opened this issue May 21, 2020 · 4 comments
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@toumorokoshi
Copy link
Member

Hi!

I recently worked with opentelemetry-specification to align on a standardized naming for instrumentations across languages. Here's the final result:

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/overview.md#instrumentation-libraries

And the PR where it was discussed:

open-telemetry/opentelemetry-specification#539

I think if js followed the specification as written, it would have a small set of renamed:

  • opentelemetry-plugin-grpc -> opentelemetry-instrumentation-grpc
  • opentelemetry-plugin-http -> opentelemetry-instrumentation-http
  • opentelemetry-plugin-https -> opentelemetry-instrumentation-https
  • opentelemetry-plugin-xml-http-request -> opentelemetry-instrumentation-plugin-xml-http-request

I wanted to raise this as a discussion as well as possibly a "bug": main question is: does this specification as written work for js?

@toumorokoshi toumorokoshi added the bug Something isn't working label May 21, 2020
@toumorokoshi
Copy link
Member Author

sorry I don't have permissions, but this probably better warrants the "discussion" tag.

@mayurkale22 mayurkale22 added Discussion Issue or PR that needs/is extended discussion. and removed bug Something isn't working labels May 21, 2020
@dyladan
Copy link
Member

dyladan commented May 22, 2020

While there are only 4 packages here, there are 8 in node contrib and 2 in web contrib.

@toumorokoshi
Copy link
Member Author

Additional discussion around this in open-telemetry/opentelemetry-js-contrib#37

@mhennoch
Copy link
Contributor

This is done no? @dyladan

@dyladan dyladan closed this as completed May 18, 2021
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

4 participants