Skip to content

Commit

Permalink
Use any and add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
mayurkale22 committed Jun 14, 2019
1 parent fafce9f commit db13c94
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions packages/opentelemetry-types/src/trace/span.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ export interface Span {
* @param key the key for this attribute.
* @param value the value for this attribute.
*/
setAttribute(key: string, value: string | number | boolean | object): this;
//tslint:disable-next-line:no-any
setAttribute(key: string, value: any): this;

/**
* Adds an event to the Span.
Expand All @@ -54,10 +55,8 @@ export interface Span {
* @param [attributes] the attributes that will be added; these are
* associated with this event.
*/
addEvent(
name: string,
attributes?: { [key: string]: string | number | boolean | object }
): this;
//tslint:disable-next-line:no-any
addEvent(name: string, attributes?: { [key: string]: any }): this;

/**
* Adds a link to the Span.
Expand All @@ -66,10 +65,8 @@ export interface Span {
* @param [attributes] the attributes that will be added; these are
* associated with this link.
*/
addLink(
spanContext: SpanContext,
attributes?: { [key: string]: string | number | boolean | object }
): this;
//tslint:disable-next-line:no-any
addLink(spanContext: SpanContext, attributes?: { [key: string]: any }): this;

/**
* Sets a status to the span. If used, this will override the default Span
Expand All @@ -82,6 +79,8 @@ export interface Span {
/**
* Updates the Span name.
*
* TODO (revision): https://github.com/open-telemetry/opentelemetry-specification/issues/119
*
* @param name the Span name.
*/
updateName(name: string): this;
Expand Down

0 comments on commit db13c94

Please sign in to comment.