fix(instrumentation-fetch)! Remove HTTP prefix in span name.

open-telemetry · Aug 28, 2024 · bf6a8bb · bf6a8bb
1 parent e311672
commit bf6a8bb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to experimental packages in this project will be documented
 ## Unreleased
 
 ### :boom: Breaking Change
+* fix(instrumentation-fetch)! Remove HTTP prefix in span name.
 
 ### :rocket: (Enhancement)
 

diff --git a/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts b/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts
@@ -206,7 +206,7 @@ export class FetchInstrumentation extends InstrumentationBase<FetchInstrumentati
       return;
     }
     const method = (options.method || 'GET').toUpperCase();
-    const spanName = `HTTP ${method}`;
+    const spanName = `${method}`;
     return this.tracer.startSpan(spanName, {
       kind: api.SpanKind.CLIENT,
       attributes: {

diff --git a/experimental/packages/opentelemetry-instrumentation-fetch/test/fetch.test.ts b/experimental/packages/opentelemetry-instrumentation-fetch/test/fetch.test.ts
@@ -362,7 +362,7 @@ describe('fetch', () => {
 
     it('span should have correct name', () => {
       const span: tracing.ReadableSpan = exportSpy.args[1][0][0];
-      assert.strictEqual(span.name, 'HTTP GET', 'span has wrong name');
+      assert.strictEqual(span.name, 'GET', 'span has wrong name');
     });
 
     it('span should have correct kind', () => {
@@ -932,7 +932,7 @@ describe('fetch', () => {
       );
       assert.strictEqual(
         exportSpy.args[0][0][0].name,
-        'HTTP GET',
+        'GET',
         'wrong span captured'
       );