fix: don't filter empty instrumentation library metrics

open-telemetry · Mar 4, 2022 · a6b1bea · a6b1bea
1 parent a5c3ad3
commit a6b1bea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/...ental/packages/opentelemetry-sdk-metrics-base/src/export/PeriodicExportingMetricReader.ts b/...ental/packages/opentelemetry-sdk-metrics-base/src/export/PeriodicExportingMetricReader.ts
@@ -64,12 +64,11 @@ export class PeriodicExportingMetricReader extends MetricReader {
   private async _runOnce(): Promise<void> {
     const metrics = await this.collect({});
 
-    return new Promise((resolve, reject) => {
-      if (metrics === undefined) {
-        resolve();
-        return;
-      }
+    if (metrics === undefined) {
+      return;
+    }
 
+    return new Promise((resolve, reject) => {
       this._exporter.export(metrics, result => {
         if (result.code !== ExportResultCode.SUCCESS) {
           reject(

diff --git a/experimental/packages/opentelemetry-sdk-metrics-base/src/state/MetricCollector.ts b/experimental/packages/opentelemetry-sdk-metrics-base/src/state/MetricCollector.ts
@@ -35,7 +35,7 @@ export class MetricCollector implements MetricProducer {
   async collect(): Promise<ResourceMetrics> {
     const collectionTime = hrTime();
     const instrumentationLibraryMetrics = (await Promise.all(this._sharedState.meters
-      .map(meter => meter.collect(this, collectionTime)))).filter(({ metrics }) => metrics.length > 0);
+      .map(meter => meter.collect(this, collectionTime))));
 
     return {
       resource: this._sharedState.resource,