Skip to content

Commit

Permalink
fix(events,logs): drop outdated API from devDependencies and align ty…
Browse files Browse the repository at this point in the history
…pes (#5013)
  • Loading branch information
pichlermarc authored Sep 25, 2024
1 parent 2a4919c commit 9de3151
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 76 deletions.
3 changes: 3 additions & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ All notable changes to experimental packages in this project will be documented

* fix(sampler-jaeger-remote): fixes an issue where package could emit unhandled promise rejections @Just-Sieb
* fix(otlp-grpc-exporter-base): default compression to `'none'` if env vars `OTEL_EXPORTER_OTLP_TRACES_COMPRESSION` and `OTEL_EXPORTER_OTLP_COMPRESSION` are falsy @sjvans
* fix(sdk-events): remove devDependencies to old `@opentelemetry/[email protected]`, `@opentelemetry/[email protected]` packages [#5013](https://github.com/open-telemetry/opentelemetry-js/pull/5013) @pichlermarc
* fix(sdk-logs): remove devDependencies to old `@opentelemetry/[email protected]` [#5013](https://github.com/open-telemetry/opentelemetry-js/pull/5013) @pichlermarc
* fix(sdk-logs): align LogRecord#setAttribute type with types from `@opentelemetry/[email protected]` [#5013](https://github.com/open-telemetry/opentelemetry-js/pull/5013) @pichlermarc

### :books: (Refine Doc)

Expand Down
2 changes: 0 additions & 2 deletions experimental/packages/sdk-events/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@
"devDependencies": {
"@babel/core": "7.25.2",
"@opentelemetry/api": "1.9.0",
"@opentelemetry/api-events": "0.52.0",
"@opentelemetry/api-logs": "0.52.0",
"@types/mocha": "10.0.8",
"@types/node": "18.6.5",
"@types/sinon": "10.0.20",
Expand Down
1 change: 0 additions & 1 deletion experimental/packages/sdk-logs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"@babel/core": "7.25.2",
"@babel/preset-env": "7.25.4",
"@opentelemetry/api": ">=1.4.0 <1.10.0",
"@opentelemetry/api-logs": "0.52.0",
"@opentelemetry/resources_1.9.0": "npm:@opentelemetry/[email protected]",
"@types/mocha": "10.0.8",
"@types/node": "18.6.5",
Expand Down
4 changes: 2 additions & 2 deletions experimental/packages/sdk-logs/src/LogRecord.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import type { IResource } from '@opentelemetry/resources';

import type { ReadableLogRecord } from './export/ReadableLogRecord';
import type { LogRecordLimits } from './types';
import { LogAttributes, LogBody } from '@opentelemetry/api-logs';
import { AnyValue, LogAttributes, LogBody } from '@opentelemetry/api-logs';
import { LoggerProviderSharedState } from './internal/LoggerProviderSharedState';

export class LogRecord implements ReadableLogRecord {
Expand Down Expand Up @@ -112,7 +112,7 @@ export class LogRecord implements ReadableLogRecord {
this.setAttributes(attributes);
}

public setAttribute(key: string, value?: LogAttributes | AttributeValue) {
public setAttribute(key: string, value?: AnyValue) {
if (this._isLogRecordReadonly()) {
return this;
}
Expand Down
74 changes: 3 additions & 71 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9de3151

Please sign in to comment.