fix(exporter-collector-grpc): incorrect default URL after 0.20.0 update

open-telemetry · Jun 8, 2021 · 99bffbe · 99bffbe
1 parent 3d98420
commit 99bffbe
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/packages/opentelemetry-exporter-collector-grpc/README.md b/packages/opentelemetry-exporter-collector-grpc/README.md
@@ -27,7 +27,7 @@ const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/tra
 const { CollectorTraceExporter } =  require('@opentelemetry/exporter-collector-grpc');
 
 const collectorOptions = {
-  // url is optional and can be omitted - default is localhost:4317
+  // url is optional and can be omitted - default is grpc://localhost:4317
   url: '<collector-hostname>:<port>',
 };
 
@@ -51,7 +51,7 @@ const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/tra
 const { CollectorTraceExporter } =  require('@opentelemetry/exporter-collector-grpc');
 
 const collectorOptions = {
-  // url is optional and can be omitted - default is localhost:4317
+  // url is optional and can be omitted - default is grpc://localhost:4317
   url: '<collector-hostname>:<port>',
   credentials: grpc.credentials.createSsl(),
 };
@@ -91,7 +91,7 @@ const metadata = new grpc.Metadata();
 metadata.set('k', 'v');
 
 const collectorOptions = {
-  // url is optional and can be omitted - default is localhost:4317
+  // url is optional and can be omitted - default is grpc://localhost:4317
   url: '<collector-hostname>:<port>',
   metadata, // // an optional grpc.Metadata object to be sent with each request
 };
@@ -116,7 +116,7 @@ The CollectorTraceExporter in Node expects the URL to only be the hostname. It w
 const { MeterProvider } = require('@opentelemetry/metrics');
 const { CollectorMetricExporter } =  require('@opentelemetry/exporter-collector-grpc');
 const collectorOptions = {
-  // url is optional and can be omitted - default is localhost:4317
+  // url is optional and can be omitted - default is grpc://localhost:4317
   url: '<collector-hostname>:<port>',
 };
 const exporter = new CollectorMetricExporter(collectorOptions);

diff --git a/packages/opentelemetry-exporter-collector-grpc/src/CollectorMetricExporter.ts b/packages/opentelemetry-exporter-collector-grpc/src/CollectorMetricExporter.ts
@@ -24,7 +24,7 @@ import { CollectorExporterNodeBase } from './CollectorExporterNodeBase';
 import { getEnv } from '@opentelemetry/core';
 import { validateAndNormalizeUrl } from './util';
 
-const DEFAULT_COLLECTOR_URL = 'localhost:4317';
+const DEFAULT_COLLECTOR_URL = 'grpc://localhost:4317';
 
 /**
  * Collector Metric Exporter for Node

diff --git a/packages/opentelemetry-exporter-collector-grpc/src/CollectorTraceExporter.ts b/packages/opentelemetry-exporter-collector-grpc/src/CollectorTraceExporter.ts
@@ -24,7 +24,7 @@ import { CollectorExporterConfigNode, ServiceClientType } from './types';
 import { getEnv } from '@opentelemetry/core';
 import { validateAndNormalizeUrl } from './util';
 
-const DEFAULT_COLLECTOR_URL = 'localhost:4317';
+const DEFAULT_COLLECTOR_URL = 'grpc://localhost:4317';
 
 /**
  * Collector Trace Exporter for Node

diff --git a/packages/opentelemetry-exporter-collector-grpc/test/CollectorTraceExporter.test.ts b/packages/opentelemetry-exporter-collector-grpc/test/CollectorTraceExporter.test.ts
@@ -204,7 +204,7 @@ describe('CollectorTraceExporter - node (getDefaultUrl)', () => {
   it('should default to localhost', done => {
     const collectorExporter = new CollectorTraceExporter({});
     setTimeout(() => {
-      assert.strictEqual(collectorExporter['url'], 'localhost:4317');
+      assert.strictEqual(collectorExporter['url'], 'grpc://localhost:4317');
       done();
     });
   });