Skip to content

Commit

Permalink
fix(instrumentation)!: pin [email protected] (#4441)
Browse files Browse the repository at this point in the history
* fix(instrumentation): pin [email protected]

* fix(changelog): add changlog entry

* Update experimental/CHANGELOG.md

Co-authored-by: Trent Mick <[email protected]>

* fix(changelog): additional details

* fix(changelog): formatting

* fix(changelog): lint

---------

Co-authored-by: Trent Mick <[email protected]>
  • Loading branch information
pichlermarc and trentm authored Jan 25, 2024
1 parent 0635ab1 commit 8648313
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 25 deletions.
6 changes: 6 additions & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ All notable changes to experimental packages in this project will be documented

### :boom: Breaking Change

* fix(instrumentation)!: pin [email protected] [#4441](https://github.com/open-telemetry/opentelemetry-js/pull/4441)
* Fixes a bug where, in some circumstances, ESM instrumentation packages would try to instrument CJS exports on ESM, causing the end-user application to crash.
* This breaking change only affects users that are using the *experimental* `@opentelemetry/instrumentation/hook.mjs` loader hook AND Node.js 18.19 or later:
* This reverts back to an older version of `import-in-the-middle` due to <https://github.com/DataDog/import-in-the-middle/issues/57>
* This version does not support Node.js 18.19 or later

### :rocket: (Enhancement)

### :bug: (Bug Fix)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
},
"dependencies": {
"@types/shimmer": "^1.0.2",
"import-in-the-middle": "^1.7.2",
"import-in-the-middle": "1.7.1",
"require-in-the-middle": "^7.1.1",
"semver": "^7.5.2",
"shimmer": "^1.2.1"
Expand Down
48 changes: 24 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8648313

Please sign in to comment.