chore: address PR comments

open-telemetry · Jan 26, 2020 · 781087f · 781087f
1 parent 6e4a2b4
commit 781087f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/opentelemetry-node/src/instrumentation/PluginLoader.ts b/packages/opentelemetry-node/src/instrumentation/PluginLoader.ts
@@ -89,7 +89,9 @@ export class PluginLoader {
       );
       if (requiredModulesToHook.length > 0) {
         this.logger.warn(
-          `Some modules (${requiredModulesToHook}) were already required when their respective plugin were loaded, some plugins might not work. Make sure the SDK is setup before you require in other modules.`
+          `Some modules (${requiredModulesToHook.join(
+            ', '
+          )}) were already required when their respective plugin was loaded, some plugins might not work. Make sure the SDK is setup before you require in other modules.`
         );
       }
 

diff --git a/packages/opentelemetry-node/test/instrumentation/PluginLoader.test.ts b/packages/opentelemetry-node/test/instrumentation/PluginLoader.test.ts
@@ -238,7 +238,7 @@ describe('PluginLoader', () => {
         },
       };
       require('already-require-module');
-      const pluginLoader = new PluginLoader(tracer, verifyWarnLogger);
+      const pluginLoader = new PluginLoader(registry, verifyWarnLogger);
       pluginLoader.load(alreadyRequiredPlugins);
       pluginLoader.unload();
     });