fix(otlp-exporters): remove more 'if's for undefined checks from tests.

open-telemetry · May 4, 2022 · 2dcb4c1 · 2dcb4c1
1 parent 47aa7e4
commit 2dcb4c1
Showing 1 changed file with 12 additions and 18 deletions.
diff --git a/experimental/packages/exporter-trace-otlp-grpc/test/OTLPTraceExporter.test.ts b/experimental/packages/exporter-trace-otlp-grpc/test/OTLPTraceExporter.test.ts
@@ -228,26 +228,20 @@ const testCollectorExporter = (params: TestParams) =>
             typeof exportedData !== 'undefined',
             'resource' + " doesn't exist"
           );
-          let spans;
-          let resource;
-          if (exportedData) {
-            spans = exportedData.scopeSpans[0].spans;
-            resource = exportedData.resource;
-
-            assert.ok(
-              typeof spans !== 'undefined',
-              'spans do not exist'
-            );
-            ensureExportedSpanIsCorrect(spans[0]);
-
-            assert.ok(
-              typeof resource !== 'undefined',
-              "resource doesn't exist"
-            );
+          const spans = exportedData.scopeSpans[0].spans;
+          const resource = exportedData.resource;
 
-            ensureResourceIsCorrect(resource);
+          assert.ok(
+            typeof spans !== 'undefined',
+            'spans do not exist'
+          );
+          ensureExportedSpanIsCorrect(spans[0]);
 
-          }
+          assert.ok(
+            typeof resource !== 'undefined',
+            "resource doesn't exist"
+          );
+          ensureResourceIsCorrect(resource);
 
           ensureMetadataIsCorrect(reqMetadata, params.metadata);