Skip to content

Commit

Permalink
fix(sdk-node): use resource interface instead of concrete class (#3803)
Browse files Browse the repository at this point in the history
  • Loading branch information
blumamir authored May 15, 2023
1 parent 758c7af commit 2531263
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ All notable changes to experimental packages in this project will be documented

### :bug: (Bug Fix)

* fix(sdk-node): use resource interface instead of concrete class [#3803](https://github.com/open-telemetry/opentelemetry-js/pull/3803) @blumamir

### :books: (Refine Doc)

### :house: (Internal)
Expand Down
4 changes: 2 additions & 2 deletions experimental/packages/opentelemetry-sdk-node/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import type { ContextManager } from '@opentelemetry/api';
import { TextMapPropagator } from '@opentelemetry/api';
import { InstrumentationOption } from '@opentelemetry/instrumentation';
import { Detector, DetectorSync, Resource } from '@opentelemetry/resources';
import { Detector, DetectorSync, IResource } from '@opentelemetry/resources';
import { MetricReader, View } from '@opentelemetry/sdk-metrics';
import {
Sampler,
Expand All @@ -34,7 +34,7 @@ export interface NodeSDKConfiguration {
metricReader: MetricReader;
views: View[];
instrumentations: InstrumentationOption[];
resource: Resource;
resource: IResource;
resourceDetectors: Array<Detector | DetectorSync>;
sampler: Sampler;
serviceName?: string;
Expand Down

0 comments on commit 2531263

Please sign in to comment.