-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Koa router name as span name if available #976
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #976 +/- ##
==========================================
+ Coverage 95.91% 96.20% +0.28%
==========================================
Files 13 18 +5
Lines 856 1000 +144
Branches 178 203 +25
==========================================
+ Hits 821 962 +141
- Misses 35 38 +3
|
@lukiano, please sign the CLA. |
I've signed the CLA |
A named route refers to a route + a method so there's no way to use a named route with different methods?
Are you aware of the TAV/test-all-versions setup and how to run it? |
I'll work on these changes today. Sorry for the delay. |
I've addressed the feedback and ran tav |
Thanks and congrats about your first contribution, @lukiano! |
Which problem is this PR solving?
operationId
for that route then it will be easier to associate spans with the OpenAPI spec.Short description of the changes
_matchedRouteName
. Note that I'm not using the formatrouter - xxx
as I'd rather have the span name clean.Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.NPM failed to compile on the untouched
main
branch (some type errors related to React)