-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readmes to follow a standard pattern #960
Conversation
|
Validating the first file commit before propagating the edit to other files, @blumamir feel free to disregard for the moment. |
I can confirm that's the idea of the issue! 👍 The wording has to be adjusted for the web bits. |
Meaning that the package is listed under the "Supported instrumentations" header? What wording would we want for the |
Codecov Report
@@ Coverage Diff @@
## main #960 +/- ##
==========================================
- Coverage 95.91% 91.68% -4.23%
==========================================
Files 13 104 +91
Lines 856 5326 +4470
Branches 178 1083 +905
==========================================
+ Hits 821 4883 +4062
- Misses 35 443 +408
|
In the readme, yes, and under
What would make sense in your opinion? |
I don't think I have sufficient context to suggest verbiage for the |
Adding those: #981
I'd use something very analogous:
|
Thank you @rauno56, I've added the updated readme introduction syntax to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks and congrats for the first contribution!
It's been two months since this PR was first filed, is this stuck on the dependent PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry about the delay and thanks for the reminder :)
Covers the node folder portion of the issue in #819.
Fixes #819