Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(redis): update readme supported versions #927

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

YanivD
Copy link
Member

@YanivD YanivD commented Mar 2, 2022

Which problem is this PR solving?

  • The readme states redis instrumentation support versions >=2.6.0 which includes version 4. But in the code version 4 is not supported, not patched and not tested.

Short description of the changes

  • redis instrumentation - updated supported versions. documented v4 is not supported yet.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@YanivD YanivD requested a review from a team March 2, 2022 09:22
@github-actions github-actions bot requested a review from blumamir March 2, 2022 09:22
@YanivD
Copy link
Member Author

YanivD commented Mar 2, 2022

Related issue - #834

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #927 (cd21e76) into main (3d1388b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #927   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          13       13           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          821      821           
  Misses         35       35           

@blumamir blumamir merged commit 9c00bf2 into open-telemetry:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants