-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): fix graphql.operation.name
field
#903
fix(graphql): fix graphql.operation.name
field
#903
Conversation
The operation-name is there to help with o11y: - https://graphql.org/learn/queries/#operation-name The operation-type (previously sent in this field) is helpful for grouping too, so send as `graphql.operation.type`.
|
@dyladan, might you be able to help move this PR out of its current state? |
plugins/node/opentelemetry-instrumentation-graphql/src/enums/AttributeNames.ts
Show resolved
Hide resolved
Just need to wait for some reviews. It's only been 24 hours since it was opened and the contributors/reviewers are in many timezones so it can take a few days sometimes. |
Codecov Report
@@ Coverage Diff @@
## main #903 +/- ##
==========================================
- Coverage 95.91% 95.23% -0.68%
==========================================
Files 13 20 +7
Lines 856 1301 +445
Branches 178 265 +87
==========================================
+ Hits 821 1239 +418
- Misses 35 62 +27
|
Hi @obecny 👋. You seem to be the last reviewer on the roster for this PR. Any chance you'd be able to take a look please? |
Hi @obecny, it's been another week. Any chance you'd be able to look at this PR please? |
@obecny is no longer a maintainer on the project. sorry for the confusion |
he is still part of the approver group and the owner of the graphql instrumentation. |
I am the right person :) |
Thank you guys! 🙏 |
Which problem is this PR solving?
graphql.operation.name
span attribute to operation type #847Short description of the changes
graphql.operation.name
to send the GraphQL operation-name (a critical field for GraphQL o11y) instead of the GraphQL operation-type.graphql.operation.type
, since this is still useful for segmenting read queries from write mutations, etc.Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.