Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows build of aws-sdk package #902

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 15, 2022

Which problem is this PR solving?

windows build fails

Short description of the changes

Correct the scope argument of precompile task in aws-sdk instrumentation to work on windows.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

Correct the scope argument of precompile task in aws-sdk instrumentation to work on windows.
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #902 (63d91a3) into main (40608b1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main     #902    +/-   ##
========================================
  Coverage   95.91%   95.91%            
========================================
  Files          13       23    +10     
  Lines         856     1346   +490     
  Branches      178      280   +102     
========================================
+ Hits          821     1291   +470     
- Misses         35       55    +20     
Impacted Files Coverage Δ
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.87% <0.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts 90.32% <0.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 89.65% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.36% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 93.75% <0.00%> (ø)

@dyladan dyladan merged commit 760c4d4 into open-telemetry:main Feb 22, 2022
@Flarna Flarna deleted the fix-win branch February 22, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants