Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update some dev-deps in fastify instrumentation #879

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 10, 2022

BEGIN_COMMIT_OVERRIDE
fix: update some dev-deps in fastify instrumentation
END_COMMIT_OVERRIDE

Which problem is this PR solving?

Short description of the changes

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@Flarna Flarna requested a review from a team February 10, 2022 22:03
@Flarna
Copy link
Member Author

Flarna commented Feb 10, 2022

Main reason for this PR is to try to get fastify instrumentation into #874 as #873 was not enough.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #879 (6b749ca) into main (8b07d97) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   95.29%   95.39%   +0.10%     
==========================================
  Files          10       15       +5     
  Lines         701      912     +211     
  Branches      142      181      +39     
==========================================
+ Hits          668      870     +202     
- Misses         33       42       +9     
Impacted Files Coverage Δ
...nstrumentation-fastify/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...try-instrumentation-fastify/src/instrumentation.ts 97.29% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.87% <0.00%> (ø)
...telemetry-instrumentation-fastify/src/constants.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-fastify/src/utils.ts 87.50% <0.00%> (ø)

@Flarna Flarna merged commit a20f77b into open-telemetry:main Feb 11, 2022
@Flarna Flarna deleted the fastify-update-deps branch February 11, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants