Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set publishConfig for test utils #662

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Sep 15, 2021

When the test util was made public its publish config was not set

@dyladan dyladan requested a review from a team September 15, 2021 15:51
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #662 (fcfaeb9) into main (798fb2d) will decrease coverage by 1.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   96.68%   95.53%   -1.16%     
==========================================
  Files          13       62      +49     
  Lines         634     4365    +3731     
  Branches      124      396     +272     
==========================================
+ Hits          613     4170    +3557     
- Misses         21      195     +174     
Impacted Files Coverage Δ
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.61% <0.00%> (ø)
...opentelemetry-resource-detector-gcp/src/version.ts 0.00% <0.00%> (ø)
...e/opentelemetry-instrumentation-redis/src/utils.ts 92.98% <0.00%> (ø)
...opentelemetry-instrumentation-ioredis/src/utils.ts 91.66% <0.00%> (ø)
...ource-detector-aws/src/detectors/AwsEksDetector.ts 91.25% <0.00%> (ø)
...metry-resource-detector-aws/src/detectors/index.ts 100.00% <0.00%> (ø)
...telemetry-instrumentation-cassandra/src/version.ts 100.00% <0.00%> (ø)
...detector-aws/test/detectors/AwsEcsDetector.test.ts 100.00% <0.00%> (ø)
...etry-instrumentation-mysql2/src/instrumentation.ts 95.00% <0.00%> (ø)
...pentelemetry-instrumentation-pg/test/utils.test.ts 98.36% <0.00%> (ø)
... and 39 more

@dyladan dyladan merged commit 1b7ae9c into open-telemetry:main Sep 15, 2021
@dyladan dyladan deleted the access-test-utils branch September 15, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants