-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(test-utils): marking test-utils as non private so it can be published #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 96.68% 95.22% -1.47%
==========================================
Files 13 67 +54
Lines 634 4582 +3948
Branches 124 426 +302
==========================================
+ Hits 613 4363 +3750
- Misses 21 219 +198
|
blumamir
changed the title
build: marking test-utils as non private so it can be published
build(test-utils): marking test-utils as non private so it can be published
Aug 25, 2021
github-actions
bot
assigned blumamir, legendecas, naseemkullah, NathanielRN, rauno56 and willarmiros
Aug 25, 2021
github-actions
bot
requested review from
legendecas,
naseemkullah,
NathanielRN,
rauno56 and
willarmiros
August 25, 2021 16:39
dyladan
approved these changes
Aug 25, 2021
willarmiros
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @dyladan hopefully this can go out in contrib release 0.25.0 so we can unblock the ext-js migrations ASAP!
vmarchaud
approved these changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #596
Which problem is this PR solving?
To my knowledge, there was no objection for it to be published to npm.
We can discuss here or on the original issue if this is not ok for any reason
Short description of the changes
test-utils
tocontrib-test-utils