Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add component owners to readme #607

Merged
merged 7 commits into from
Aug 9, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 6, 2021

Adding owners to the readme, but also this PR serves as a test of the github action.

@dyladan dyladan requested a review from a team August 6, 2021 17:33
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #607 (8ca9d31) into main (95aa84f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   94.94%   94.93%   -0.02%     
==========================================
  Files         195      192       -3     
  Lines       11637    11363     -274     
  Branches     1115     1047      -68     
==========================================
- Hits        11049    10787     -262     
+ Misses        588      576      -12     
Impacted Files Coverage Δ
...ation-user-interaction/src/enums/AttributeNames.ts
...umentation-user-interaction/src/instrumentation.ts
...ry-instrumentation-user-interaction/src/version.ts

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked like a charm! This GH Action could probably be shared with the TC, I feel like many otel repos could benefit from this.

@dyladan
Copy link
Member Author

dyladan commented Aug 9, 2021

Worked like a charm! This GH Action could probably be shared with the TC, I feel like many otel repos could benefit from this.

https://cloud-native.slack.com/archives/C01NJ7V1KRC/p1628259438015800

@dyladan
Copy link
Member Author

dyladan commented Aug 9, 2021

Looks like the action re-requested the review when a change was pushed. Updated it to not do that

@dyladan dyladan merged commit a295efe into open-telemetry:main Aug 9, 2021
@dyladan dyladan deleted the ownership-readme branch August 9, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants